Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve cosmos-sdk detection #3833

Merged
merged 9 commits into from
Dec 12, 2023
Merged

fix: improve cosmos-sdk detection #3833

merged 9 commits into from
Dec 12, 2023

Conversation

julienrbrt
Copy link
Member

@julienrbrt julienrbrt commented Dec 8, 2023 •
edited
Loading

Closes: #3832

  • Allow Ignite to work with Cosmos SDK forks
  • Properly display the correct SDK version when using a fork

@julienrbrt julienrbrt marked this pull request as ready for review December 8, 2023 18:45
@julienrbrt julienrbrt force-pushed the julien/improve-sdk-detection branch from 2fd20a2 to baebef5 Compare December 8, 2023 20:47
@julienrbrt julienrbrt marked this pull request as draft December 8, 2023 20:47
@julienrbrt julienrbrt marked this pull request as ready for review December 8, 2023 20:53
Pantani
Pantani previously approved these changes Dec 12, 2023
View reviewed changes
Copy link
Collaborator

@Pantani Pantani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!! LGMT!!!!

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

Merging #3833 (dea27f3) into main (c148343) will increase coverage by 0.07%.
The diff coverage is 35.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3833      +/-   ##
==========================================
+ Coverage   24.25%   24.32%   +0.07%     
==========================================
  Files         292      292              
  Lines       24516    24517       +1     
==========================================
+ Hits         5946     5964      +18     
+ Misses      18032    18016      -16     
+ Partials      538      537       -1
Files Coverage Δ
ignite/pkg/cosmosanalysis/cosmosanalysis.go 84.02% <100.00%> (+0.08%) ⬆️
ignite/pkg/cosmosver/cosmosver.go 59.09% <ø> (+18.18%) ⬆️
ignite/pkg/gomodule/gomodule.go 56.84% <ø> (+5.26%) ⬆️
ignite/pkg/cosmosanalysis/app/app.go 58.00% <66.66%> (+0.14%) ⬆️
ignite/version/version.go 4.03% <50.00%> (+4.03%) ⬆️
ignite/pkg/cosmosbuf/buf.go 4.72% <0.00%> (ø)
ignite/pkg/cosmosver/detect.go 60.00% <50.00%> (+6.15%) ⬆️
ignite/pkg/cosmosgen/generate.go 0.00% <0.00%> (ø)

@julienrbrt julienrbrt enabled auto-merge (squash) December 12, 2023 16:03
@Pantani Pantani self-requested a review December 12, 2023 17:24
@julienrbrt julienrbrt merged commit 6f71676 into main Dec 12, 2023
43 checks passed
@julienrbrt julienrbrt deleted the julien/improve-sdk-detection branch December 12, 2023 17:36
@julienrbrt julienrbrt mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pantani Pantani Pantani approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Ehsan-saradar Ehsan-saradar Awaiting requested review from Ehsan-saradar

@salmad3 salmad3 Awaiting requested review from salmad3 salmad3 is a code owner

@toschdev toschdev Awaiting requested review from toschdev toschdev is a code owner

Assignees

@julienrbrt julienrbrt

Labels
component:ci CI/CD workflow and automated jobs. component:configs component:packages type:internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cosmos SDK package version not found
2 participants
@julienrbrt @Pantani